Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all json config files to use snake case property names #1730

Closed
kaidaguerre opened this issue Mar 24, 2022 · 1 comment · Fixed by #1823
Closed

Migrate all json config files to use snake case property names #1730

kaidaguerre opened this issue Mar 24, 2022 · 1 comment · Fixed by #1823
Assignees
Labels
house-keeping General stuff which take time, but doesn't necessarily require new knowledge or is high priority
Milestone

Comments

@kaidaguerre
Copy link
Contributor

John Smyth:

That is our 'standard' for the steampipe cloud api.  It seems like we have a mix in steampipe today - versions.json and update-check.json are lowerCamel, plugin_manager.json and steampipe.json are UpperCamel...  Not urgent, but we should probably migrate to a standard format.

We should also look at updating the names for consistency of - vs _ (see also #402)
Files to update:

versions.json
update-check.json
plugin_manager.json
steampipe.json
.mod.cache.json
@kaidaguerre kaidaguerre added the house-keeping General stuff which take time, but doesn't necessarily require new knowledge or is high priority label Mar 24, 2022
@kaidaguerre kaidaguerre added this to the v0.14.0 milestone Mar 24, 2022
@kaidaguerre
Copy link
Contributor Author

type Migrateable interface{
      MigrateFrom(old interface{})
}


func Migrate(old interface{}, new Migrateable, filepath)Migrateable{
     // deserialise into new
     if structVersion == expected{ return}
 
     // deserialise into old
     new.MigrateFrom(old)

   // serialise to file
     return new
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
house-keeping General stuff which take time, but doesn't necessarily require new knowledge or is high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants