Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output of plugin update #1780

Closed
kaidaguerre opened this issue Apr 1, 2022 · 1 comment · Fixed by #1808
Closed

Improve output of plugin update #1780

kaidaguerre opened this issue Apr 1, 2022 · 1 comment · Fixed by #1808
Assignees
Milestone

Comments

@kaidaguerre
Copy link
Contributor

kaidaguerre commented Apr 1, 2022

The exact design need to be determined and discussed with @MichaelBurgess @e-gineer @johnsmyth

At the least, list the plugins in alphabetical order. (further discussion below)

mike @ ~/Code/github.com/turbot/steampipe (main) > ./steampipe plugin update --all

Updated plugin: oci@latest v0.9.0
Documentation:  https://hub.steampipe.io/plugins/turbot/oci

Updated plugin: aws@latest v0.50.1
Documentation:  https://hub.steampipe.io/plugins/turbot/aws

Updated plugin: chaos@latest v0.0.10
Documentation:  https://hub.steampipe.io/plugins/turbot/chaos

Skipped the following plugins:

Plugin:   gitlab@latest
Reason:   Latest already installed

Plugin:   confluence@latest
Reason:   Latest already installed

Plugin:   zendesk@latest
Reason:   Latest already installed

Plugin:   urlscan@latest
Reason:   Latest already installed

Plugin:   steampipecloud@latest
Reason:   Latest already installed

Plugin:   cloudflare@latest
Reason:   Latest already installed

Plugin:   steampipe@latest
Reason:   Latest already installed

Plugin:   kubernetes@latest
Reason:   Latest already installed

Plugin:   abuseipdb@latest
Reason:   Latest already installed

Plugin:   updown@latest
Reason:   Latest already installed

Plugin:   bitbucket@latest
Reason:   Latest already installed

Plugin:   finance@latest
Reason:   Latest already installed

Plugin:   datadog@latest
Reason:   Latest already installed

Plugin:   grafana@latest
Reason:   Latest already installed

Plugin:   net@latest
Reason:   Latest already installed

Plugin:   docker@latest
Reason:   Latest already installed

Plugin:   ibm@latest
Reason:   Latest already installed

Plugin:   heroku@latest
Reason:   Latest already installed

Plugin:   twilio@latest
Reason:   Latest already installed

Plugin:   zoom@latest
Reason:   Latest already installed

Plugin:   hackernews@latest
Reason:   Latest already installed

Plugin:   linode@latest
Reason:   Latest already installed

Plugin:   terraform@latest
Reason:   Latest already installed

Plugin:   vsphere@latest
Reason:   Latest already installed

Plugin:   rss@latest
Reason:   Latest already installed

Plugin:   alicloud@latest
Reason:   Latest already installed

Plugin:   googleworkspace@latest
Reason:   Latest already installed

Plugin:   keycloak@latest
Reason:   Latest already installed

Plugin:   scaleway@latest
Reason:   Latest already installed

Plugin:   turbot@latest
Reason:   Latest already installed

Plugin:   config@latest
Reason:   Latest already installed

Plugin:   ipstack@latest
Reason:   Latest already installed

Plugin:   code@latest
Reason:   Latest already installed

Plugin:   hypothesis@latest
Reason:   Latest already installed

Plugin:   azuread@latest
Reason:   Latest already installed

Plugin:   pagerduty@latest
Reason:   Latest already installed

Plugin:   equinix@latest
Reason:   Latest already installed

Plugin:   twitter@latest
Reason:   Latest already installed

Plugin:   googledirectory@latest
Reason:   Latest already installed

Plugin:   slack@latest
Reason:   Latest already installed

Plugin:   azure@latest
Reason:   Latest already installed

Plugin:   scalingo@latest
Reason:   Latest already installed

Plugin:   hcloud@latest
Reason:   Latest already installed

Plugin:   vault@latest
Reason:   Latest already installed

Plugin:   ldap@latest
Reason:   Latest already installed

Plugin:   okta@latest
Reason:   Latest already installed

Plugin:   prometheus@latest
Reason:   Latest already installed

Plugin:   splunk@latest
Reason:   Latest already installed

Plugin:   whois@latest
Reason:   Latest already installed

Plugin:   tfe@latest
Reason:   Latest already installed

Plugin:   stripe@latest
Reason:   Latest already installed

Plugin:   jira@latest
Reason:   Latest already installed

Plugin:   github@latest
Reason:   Latest already installed

Plugin:   digitalocean@latest
Reason:   Latest already installed

Plugin:   shodan@latest
Reason:   Latest already installed

Plugin:   gcp@latest
Reason:   Latest already installed

Plugin:   googlesheets@latest
Reason:   Latest already installed

Plugin:   virustotal@latest
Reason:   Latest already installed
@kaidaguerre kaidaguerre added this to the april_8 milestone Apr 1, 2022
@kaidaguerre
Copy link
Contributor Author

[Mike Burgess] I also find it a little hard to see the actual plugin names - I find Plugin: and Reason: on each row is a little distracting / redundant

[Mike Burgess]
Might look nicer in a table (which ties nicely with the CLI), perhaps:
Updated the following plugins:

+------------+---------+---------------------------------------------+
| Plugin | Version | Documentation |
+------------+---------+---------------------------------------------+
| aws@latest | v0.50.1 | https://hub.steampipe.io/plugins/turbot/aws |
+------------+---------+---------------------------------------------+

Skipped the following plugins:

+------------+--------------------------+
| Plugin | Reason |
+------------+--------------------------+
| gcp@latest | Latest already installed |
| oci@latest | Latest already installed |
| tfe@latest | Latest already installed |
+------------+--------------------------+

[Nathan Wallace]
I agree this needs improving, but I'm not sure if user the table.

Alphabetical definitely


[Mike Burgess]Interestingly, as you install more plugins, the actual bit you care most about (what got updated) may well get hidden off screen, so putting the updated plugins at the end might make more sense, closest to your eyes/cursor once output.
Or a summary sentence at the end like Updated 3 plugins, skipped 46 plugins to let you know if you need to scroll back up for more detail.

If not table, definitely need to remove the same text off each row - I’d vote for table though - nice way to lay out data with the same keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants