Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin update times out with > 10 plugins #234

Closed
kaidaguerre opened this issue Feb 26, 2021 · 0 comments · Fixed by #237
Closed

plugin update times out with > 10 plugins #234

kaidaguerre opened this issue Feb 26, 2021 · 0 comments · Fixed by #237
Assignees
@binaek
Labels
bug Something isn't working
Milestone
0.2.3

Comments

@kaidaguerre
Copy link
Contributor

currently the call to plugin update check url silently times out if sending a payload with > 10 plugins

We need to (some or all):

  • increase timeout
  • report when failure occurs
  • speed up the endpoint
  • make the update check asyncronous - either report results at end of session or at start of next session
@kaidaguerre kaidaguerre added the bug Something isn't working label Feb 26, 2021
@kaidaguerre kaidaguerre added this to the 0.2.3 milestone Feb 26, 2021
@binaek binaek linked a pull request Mar 1, 2021 that will close this issue
plugin update refactoring. Closes #216. Closes #234 #237
Merged
kaidaguerre pushed a commit that referenced this issue Mar 3, 2021
@binaek
plugin update now checks installed versions before updating. Increa…
984f279 
…se timeout for update request. Closes #216. Closes #234
kaidaguerre pushed a commit that referenced this issue Mar 4, 2021
@binaek @kaidaguerre
plugin update now checks installed versions before updating. Increa…
3e3bf39 
…se timeout for update request. Closes #216. Closes #234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binaek binaek

Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.3
Development

Successfully merging a pull request may close this issue.

plugin update refactoring. Closes #216. Closes #234 turbot/steampipe
2 participants
@binaek @kaidaguerre