Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI and Plugin update check should be asynchronous #2770

Closed
binaek opened this issue Nov 21, 2022 · 0 comments · Fixed by #2775
Closed

CLI and Plugin update check should be asynchronous #2770

binaek opened this issue Nov 21, 2022 · 0 comments · Fixed by #2775
Assignees
@binaek

Comments

@binaek
Copy link
Contributor

binaek commented Nov 21, 2022

CLI and Plugin update checkers should not directly report any updates. Instead, these will write out a notifications.json file which will contains the notifications that need to be displayed.

During bootstrap, the CLI will check for the existence of the notifications.json file.

If the file exists, it will display any notifications stored in the file and remove it.
@binaek binaek self-assigned this Nov 21, 2022
@binaek binaek changed the title CLI and Plugin update check should be asynchronous CLI and Plugin update check should be asynchronous Nov 21, 2022
@binaek binaek linked a pull request Nov 21, 2022 that will close this issue
Updates the update checker to run asynchronously. #2775
Merged
kaidaguerre pushed a commit that referenced this issue Nov 25, 2022
@binaek
Update the update checker to run asynchronously. Closes #2770
d2f8541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binaek binaek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates the update checker to run asynchronously. turbot/steampipe
1 participant
@binaek