Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When shutting down an implicit service, we should always shutdown if there are no other steampipe clients connected to it. #2833

Closed
binaek opened this issue Dec 5, 2022 · 0 comments · Fixed by #2835
Assignees

Comments

@binaek
Copy link
Contributor

binaek commented Dec 5, 2022

Right now, when a steampipe command is exiting, it doesn't shutdown the service if there are other clients connected to it. This is to prevent the other clients from losing connection.

However, if the aforementioned "other client" is a non-steampipe executable, that will not stop the service and this will keep the service hanging around and will also prevent the next steampipe service start since postgres does not allow updates to listen_addresses while it is running.

@binaek binaek self-assigned this Dec 5, 2022
kaidaguerre pushed a commit that referenced this issue Dec 12, 2022
pskrbasu pushed a commit that referenced this issue Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant