Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mod install and mod update run to completion even if there are unsatisfied requirements #3291

Closed
binaek opened this issue Apr 3, 2023 · 1 comment · Fixed by #3295
Closed

mod install and mod update run to completion even if there are unsatisfied requirements #3291

binaek opened this issue Apr 3, 2023 · 1 comment · Fixed by #3295
Assignees
@binaek
Labels
bug Something isn't working

Comments

@binaek
Copy link
Contributor

binaek commented Apr 3, 2023

Steampipe mods have requirements for minimum steampipe version and plugin versions. In installations where these requirements are unsatisfied, mod install and mod update should fail.
@binaek binaek added the bug Something isn't working label Apr 3, 2023
@binaek binaek self-assigned this Apr 3, 2023
@binaek binaek linked a pull request Apr 3, 2023 that will close this issue
Fixes issue where mod install/update continues installation even with unsatisfied requirements #3295
Merged
@kaidaguerre
Copy link
Contributor

duplicate of #3041

@kaidaguerre kaidaguerre reopened this Apr 6, 2023
@kaidaguerre kaidaguerre closed this as not planned Won't fix, can't repro, duplicate, stale Apr 6, 2023
kaidaguerre pushed a commit that referenced this issue Apr 6, 2023
@binaek
Fixes issue where mod install/update continues installation even with…
473a3e0 
… unsatisfied requirements. Closes #3291
kaidaguerre added a commit that referenced this issue Apr 13, 2023
@kaidaguerre
Add ctx to ModInstaller functions. #3291
62488d3
kaidaguerre added a commit that referenced this issue Apr 20, 2023
@kaidaguerre
Revert "Fixes issue where mod install/update continues installation e…
b7b3d48 
…ven with unsatisfied requirements. Closes #3291"

This reverts commit 473a3e0.
@chenrui333 chenrui333 mentioned this issue May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binaek binaek

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@binaek @kaidaguerre