Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move versions.json to the plugins dir #576

Closed
johnsmyth opened this issue Jun 29, 2021 · 2 comments
Closed

move versions.json to the plugins dir #576

johnsmyth opened this issue Jun 29, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@johnsmyth
Copy link

Is your feature request related to a problem? Please describe.
Espeially when running in docker: the $INSTALL_DIR/internal/ directory must always be read/write, but you may want the steampipe, postgres, and plugin binaries to be installed in the container image, and/or read only. Because the versions.json is tied to the installation of the plugins, it makes sense to store it with them (otherwise the versions.json may not match the installed plugins)

Describe the solution you'd like
move versions.json from $INSTALL_DIR/internal/ to $INSTALL_DIR/plugins/

@johnsmyth johnsmyth added the enhancement New feature or request label Jun 29, 2021
@binaek
Copy link
Contributor

binaek commented Jun 30, 2021

@johnsmyth the versions.json file also stores the installation details of the service and the fdw which are installed from the registry.

Should we try to move those details onto a separate file?

@johnsmyth
Copy link
Author

@binaek89 perhaps we should consolidate the service and fdw installation data with the data in the signature file ~/.steampipe/db/12.1.0/postgres/signature, and separate out the plugin versions, so we would have some like ~/.steampipe/plugins/plugin-versions.json and ~/.steampipe/db/12.1.0/postgres/db-versions.json, and the db-versions.json would contain the db and fdw info that is currently in the signature file AND the version flie?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants