-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not abort when unrelated connections are not yet loaded #4233
fix: do not abort when unrelated connections are not yet loaded #4233
Conversation
Submitted a reproduction case: https://github.com/pdecat/steampipe-4233-repro |
0a5b8a0
to
68c3fe7
Compare
38b3446
to
3bcdc14
Compare
3bcdc14
to
4b663e0
Compare
0e72e8c
to
fc45610
Compare
fc45610
to
e873694
Compare
hi @pdecat Came back to this today and I think it's a fine tactical fix for now. I'd still like to get to the bottom of it but I'll merge in the meantime. |
Hi @kaidaguerre, no problem for the delay, been using my own fork until now :) Thanks! 🎉 |
The issue described in the PR description reproduces with HEAD of v0.23.x branch with FDW 1.11.3:
|
Using strings on the official v1.11.3 build of FDW, I can verify that my changes are not included as this first command should have returned something:
If I remove the
|
This PR resolves issues when connection configurations are created dynamically concurrently to executing queries.
Symptoms are that an unrelated connection that hasn't completed loading breaks other connections:
This problem seems to happen more frequently when connections are slower to load, most notably when limiters are configured.
See https://turbot-community.slack.com/archives/C01UECB59A7/p1712324097931309
For this change to be effective, the FDW has to be rebuilt with: