Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: separated type providers #97

Merged
merged 2 commits into from
Sep 24, 2024
Merged

feat: separated type providers #97

merged 2 commits into from
Sep 24, 2024

Conversation

Bram-dc
Copy link
Contributor

@Bram-dc Bram-dc commented Jul 8, 2024 •
edited
Loading

I modified the type provider to work correctly with the changes in this PR, which has been added to fastify v5:

PR
Discussion

This was referenced Jul 8, 2024
Closed
Open
Closed
@thelinuxlich
Copy link

+1, this is important to migrate to Fastify v5

@Bram-dc
Copy link
Contributor Author

Bram-dc commented Sep 20, 2024 •
edited
Loading

@turkerdev fastify 5.0.0 has been released recently, could you take a look?
I am now using my fork in npm: https://www.npmjs.com/package/@bram-dc/fastify-type-provider-zod

@Bram-dc Bram-dc mentioned this pull request Sep 23, 2024
Closed
@kibertoad
Copy link
Collaborator

thank you! will review today

kibertoad
kibertoad reviewed Sep 23, 2024
View reviewed changes
package.json Outdated
@@ -19,7 +19,7 @@
"prepublishOnly": "npm run build"
},
"peerDependencies": {
"fastify": "^4.0.0",
"fastify": "^5.0.0-alpha.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you bump this to a final release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@kibertoad
Copy link
Collaborator

@Bram-dc thank you! will merge after creating a v4 branch

@kibertoad
Copy link
Collaborator

@Bram-dc CI is failing

@Bram-dc
Copy link
Contributor Author

Bram-dc commented Sep 23, 2024

Should be fixed now

@kibertoad
Copy link
Collaborator

@Bram-dc still failed

@Bram-dc
Copy link
Contributor Author

Bram-dc commented Sep 23, 2024

I think fastify does not support node 16 anymore:

image

@kibertoad
Copy link
Collaborator

please drop it from the matrix then

@Bram-dc
Copy link
Contributor Author

Bram-dc commented Sep 23, 2024

Fastify v5 will only support Node.js v20+. If you are using an older version of Node.js, you will need to upgrade to a newer version to use Fastify v5. https://fastify.dev/docs/latest/Guides/Migration-Guide-V5/

@kibertoad
Copy link
Collaborator

fastify is node 20+ now

@kibertoad
Copy link
Collaborator

@Bram-dc could you please resolve conflicts?

@kibertoad
Copy link
Collaborator

@Bram-dc can you rebase to have proper diff?

@kibertoad kibertoad merged commit 0110eb0 into turkerdev:main Sep 24, 2024
6 checks passed
@kibertoad
Copy link
Collaborator

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

@turkerdev turkerdev Awaiting requested review from turkerdev turkerdev is a code owner

@rupert-mckay rupert-mckay Awaiting requested review from rupert-mckay rupert-mckay is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bram-dc @thelinuxlich @kibertoad