normalize and escape regex to properly filter. fixes #78

turn-project · Mar 14, 2014 · ab1065b · citizen428 · Mar 14, 2014 · daniely
1 parent c6bed42
commit ab1065b
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/lib/turn/runners/minirunner.rb b/lib/turn/runners/minirunner.rb
@@ -70,9 +70,9 @@ def _run_suite suite, type
       # suites are cases in minitest
       @turn_case = @turn_suite.new_case(suite.name)
 
-      filter = @options[:filter] || @turn_config.pattern || /./
+      filter = normalize_filter(@options[:filter]) || @turn_config.pattern || /./
 
-      suite.send("#{type}_methods").grep(filter).each do |test|
+      suite.send("#{type}_methods").grep(/#{filter}/).each do |test|
         @turn_case.new_test(test)
       end
 
@@ -122,6 +122,14 @@ def puke(klass, meth, err)
       super(klass, meth, err)
     end
 
+    private
+
+    # regex gets turned into a string literal with leading/trailing slashes
+    # so remove them
+    def normalize_filter(filter)
+      filter.sub(/^(\/)/, '').sub(/(\/)$/, '') if filter
+    end
+
   end
 
 end