Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bunch of has_* tests #23

Merged
merged 8 commits into from
Sep 15, 2021
Merged

Bunch of has_* tests #23

merged 8 commits into from
Sep 15, 2021

Conversation

smn
Copy link
Contributor

@smn smn commented Sep 14, 2021 •
edited
Loading

@smn smn requested a review from a team September 14, 2021 13:01
@smn smn self-assigned this Sep 14, 2021
yaseenisolated
yaseenisolated approved these changes Sep 14, 2021
View reviewed changes
Copy link

@yaseenisolated yaseenisolated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :D

@smn
Copy link
Contributor Author

smn commented Sep 14, 2021

Realised I still need to fix the handling of the custom :test_result return type

@smn
Copy link
Contributor Author

smn commented Sep 15, 2021

I'm deciding to stay away with the .match stuff for now as I think that'll require a relook at the parser + AST setup that I'm unable to take on right now. For now each of these test functions returns a boolean and nothing else, which I expect is enough for them to fulfil their test functions in rc3.

@smn smn merged commit 4009795 into develop Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaseenisolated yaseenisolated yaseenisolated approved these changes

@rudigiesler rudigiesler Awaiting requested review from rudigiesler

Assignees

@smn smn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smn @yaseenisolated