-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database schema inconsistent with clean install #517
Comments
Sorry, haven't really had a chance to go through this in any detail and about to go on leave but this seems to roughly be doing what's needed - i.e. either fix install.xml or upgrade.php for fields and then have an upgrade script which cleans things up. Would it be worth us upgrading on one of our test sites? |
I've just run an upgrade with develop branch of plagiarism plugin (+ PR 553 which is not relevant to this issue but is for our own pre-3.9 testing) plagiarism_turnitin_users
plagiarism_turnitin_courses
|
Just had a look back at https://github.com/turnitin/moodle-plagiarism_turnitin/pull/542/files#diff-fcb317575e9e6245fdf1590e51a86685b61c2cc9573a9df8034323ccb3ef614fR447 and it does seem like there was no upgrade steps for those 2 fields. Might have been intentional as I can see it was reverted here - e009474 |
Yeah, I got the same @aspark21 |
Hey @aspark21 @jmcgettrick could you please check if #585 would work for you? |
I'll have a look |
Hi @aspark21 |
Hey @aspark21 @jmcgettrick Cheers, |
Please feel free to let me know if there anything I can help with this one. Kind regards, |
Ah yes sorry this dropped off my radar, I'll try and look at it this week. |
Thank you @aspark21 |
Fix issue turnitin#517 and turnitin#482 (cherry-pick turnitin#585 and turnitin#611
Hi @aspark21 Sorry for chasing you, but we have an open ticket wich I can't close untill this is fixed. Is there any chance to have a look at the issue? If there anything that needs to be changed in the PR I'm happy to do so. Kind regards, |
I've finally taken a look apologies for delay. Starting point:
Upgraded to latest plagiarism_turnitin origin master (2021091501)
Upgraded to golenkovm/issue517_v2 No more warnings from Unfortunately John has left Turnitin so it looks like @dominicgunn or @stvleung as the current owners of the Turnitin Github will have to review instead |
Can always try @dwinn but is a long shot, he might also have left. |
Thanks @aspark21 for having a look |
Hey @dominicgunn @stvleung @dwinn Can somebody please merge this PR? Kind regards, |
Hi @dominicgunn @stvleung @dwinn Is there a chance you could have a look at this PR? Thanks in advance. Appreciate this. Kind regards, |
Hi @dominicgunn @stvleung @dwinn Please feel free to let me know if I can do anything to help you with this PR. Appreciate this. Kind regards, |
Please, anyone @dominicgunn @stvleung @dwinn |
Hi @golenkovm , |
Thank you for reporting this. Because the latest version of the plagiarism plugin is supported for versions of Moodle 4.1 and higher, I am closing this ticket. However, if you find this issue is occurring with the latest version of the plugin in any of the supported Moodle versions, please create a new ticket and we will address it. |
Run: php admin/cli/check_database_schema.php
Database schema inconsistent with clean install. Running this for a core issue in 3.9 where there were some steps missing from the db/upgrade.php compared to the install.xml (MDL-69049) we have picked up on the following inconsistencies with this plugin:
The text was updated successfully, but these errors were encountered: