Only include composer in apps that use it

[JedMeister]

As a streamlining/minimisation measure, we should only include composer in apps that use it. Although LAMP and LAPP should probably be exceptions to the rule.

To do that, we should remove the composer.mk from the common lamp.mk & lapp.mk and just manually add it to the Makefile of LAMP, LAPP and any appliance that uses it.

The apps that will need the changes (i.e. ones that use composer, or we decide to include it) have been noted below and tagged in this issue.

• Remove from lamp.mk & lapp.mk common makefiles

Add to appliance Makefiles

• lamp
• lapp
• bagisto
• cakephp [note: buildcode doesn't yet use it (see CakePHP - use composer to install #1591) - but would be useful for users, so included now]
• drupal7
• drupal8
• drupal9
• ezplatform
• laravel
• magento
• moodle
• silverstripe
• snipe-it
• typo3

[JedMeister]

Removed suitecrm - turns out that it wasn't actually using composer (it was in the conf script but commented out): turnkeylinux-apps/suitecrm@c41228e

[OnGle]

ping @JedMeister

[JedMeister]

@OnGle - this is another one that we'll need to double check with repos that it's been done (or not). I have update the checklist with the merged PRs noted here, but there are still some outstanding (they may have been done, but I can't confirm right now).

[JedMeister]

Removed snipe-it - it uses composer now anyway...

[JedMeister]

Actually, I've just made an executive decision to close this issue....