New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samba appears broken if password includes parentheses (?) #861
Samba appears broken if password includes parentheses (?) #861
Comments
I don't know how to label this for domain controller - sorry. |
Could you post the output of |
Aaaaaaaand
|
What VM type are you using (VMWare, Virtual Box, etc..) and did you install via ISO or other type of image. And you are talking about the Domain Controller appliance correct? I want to try an recreate your issue on my test lab. |
Virtual Box and I first tried the OVA and subsequently tried installing from the ISO with the same results. My domain name is redacted (i also tried redacted and redacted which I use internally) and domain is REDACTED - |
Okay - I may have something useful here: it appears that if I use a different password, it'll work? The password I was initially using had parentheses in it - other than that, capital, lowercase, and numbers. When I changed to a different password, it appears to have worked even with my custom domain. I'm not certain that the parentheses are the issue, but that so far would be my guess. |
Give me about an hour and I'll try to reproduce. I'm in the middle of moving some furniture, when I get back I'll give it a try. Try spinning up something with a password with just numbers and letters to double check the password idea if you have the time. I'll post back when I have had a chance to spin up one |
Using a different password DOES allow me to use webmin and samba! It still had a special character, but it wasn't parentheses. Of course, I still can't attach my computer to the domain, but that's another issue (and might just be because my computer is a Mac... :P I have no idea how Macs integrate with AD and using samba as the DC might complicate things) |
Great to hear it is working. Macs joined to AD domain is tricky I have to do this at work for 802.11X and our wireless. I would look at using the open source project called NoMAD. Due to how macs use AD I don't recommend using it for laptops for authentication (mobile accounts) |
Ok, so I have built the domain-controller appliance for v14.2, it should be published next week hopefully. I was seriously close to shutting this issue. However, I'm not really sure if we've actually resolved this specific issue in v14.2!? To clarify, the specific problem in this case was that the interactive firstboot inithook accepted a parentheses (i.e. a If that's the case, we probably should repin this issue to v15.0 and when we get to that, tweak the inithook either so it does accept parentheses properly (and work). Or note that it can't accept them and fail if they're included. |
Clarified subject, added a brief overview of the updated issue (in the OP) and moved to v15.0 milestone. |
@spaghettimaster - assigned this one to you too. IIRC there is a way to limit which characters the inithooks can receive. If it's not obvious to you, please check with @OnGle |
Hey @JedMeister, I tested other Samba-based appliances and can reproduce this problem only in the domain-controller. So I implemented my fix locally. Here is PR. |
Thanks mate! 👍 |
This issue appears to be caused by the use of parentheses in the Samba password (via inithook). Needs testing and confirmation. - @JedMeister
I installed the VM, answered the questions with my password and domain name, connected to webmin, and went to the samba page. It said
The configuration file /etc/samba/smb.conf was not found. Most likely Samba is not installed on your system, or your module configuration is incorrect.
Based off this issue I tried reinstalling winbind and got this output:I tried doing the same using the default
domain.lan
andDOMAIN
and then webmin worked. I haven't tested beyond this to find out if it's working as an actual DC.The text was updated successfully, but these errors were encountered: