Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more feature flags, bump worker version #40

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Fix more feature flags, bump worker version #40

merged 1 commit into from
Aug 10, 2023

Conversation

LucioFranco
Copy link
Collaborator

No description provided.

@LucioFranco LucioFranco requested review from psarna and removed request for psarna August 9, 2023 18:00
@LucioFranco LucioFranco marked this pull request as ready for review August 9, 2023 21:11
@psarna
Copy link
Contributor

psarna commented Aug 10, 2023

@LucioFranco my (blocking) problem with bumping workers from 0.0.12 was https://github.com/psarna/country-counter/blob/master/Cargo.toml#L16 . It was a very sneaky thing that only fired at runtime, but I see that the bug got fixed with newer wasm-pack, and it no longer breaks as long as you use a new enough worker-build version in wrangler.toml, like here: https://github.com/psarna/country-counter/blob/09fa0d000289c9b579364f85c50196cdea0c62f8/wrangler.toml#L9 .

Since I verified that it works with newer libs, lgtm.

@psarna psarna merged commit 6633894 into main Aug 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aifrim aifrim aifrim approved these changes

@psarna psarna psarna approved these changes

@glommer glommer Awaiting requested review from glommer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucioFranco @psarna @aifrim