-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add WasmEdge as a UDF runtime #94
Comments
Thanks! I even experimented a little bit with WasmEdge API back in November - https://github.com/psarna/libsql/commits/wasmedge_poc. This branch is very much not up-to-date, but once I finish some other priority items, I'll get back to it |
Please let us know how we can be of assistance. I think the integration still needs to be done by the libsql team. But if there is any questions / feature requests for the WasmEdge SDK, we would be more than happy to help. And after the integration, we could help developing some use cases. 🤝 |
Update: I was preempted from UDF for quite a while, but I spent some time this week to recover and rebase my early patch for WasmEdge support. I have ints and floats working as well as a functional CI (which does not pass tests yet, expected). I'm also on vacation next week, but right after that I'll try to deliver a working WasmEdge support. Then we can figure out a nice demo or use case. Thanks! |
That sounds great! Look forward to seeing it running! |
@juntao and see you at wasmio.tech! (: |
#131 now has all the types working, but it's still not mergeable - the test suite needs to be updated in order to cover it, and we should perhaps add some automation for downloading libwasmedge if somebody decides to use it. (I'm on archlinux where some good person already created an AUR package for wasmedge, but rest of the distros are not covered to the best of my knowledge) |
WasmEdge has official packages on Fedora and Red Hat EPEL https://packages.fedoraproject.org/pkgs/wasmedge/wasmedge/index.html 🤝 |
Perfect! |
I think the script can just get the slim version of WasmEdge runtime from our release page like this: The |
Yeah, that's precisely what I've done in the CI script that runs on Ubuntu 👌 |
Happy new year! And congratulations on the successful incorporation of Wasm UDFs into the libsql project! As we had discussed in the PR, we would like to explore adding WasmEdge as an option for UDFs in libsql. The rationales are as follows.
WasmEdge supports a comprehensive Rust SDK and C SDK to make integration easier. I think we could provide a compile time or runtime flag to switch between supported Wasm runtimes. Please let me know what you think! Thanks.
The text was updated successfully, but these errors were encountered: