treewide: apply clippy

libsql-replication/src/replicator.rs

@@ -314,7 +314,7 @@ impl<C: ReplicatorClient> Replicator<C> {
 /// Helper function to convert rpc frames results to replicator frames
 pub fn map_frame_err(f: Result<RpcFrame, Status>) -> Result<Frame, Error> {
     let frame = f?;
-    Ok(Frame::try_from(&*frame.data).map_err(|e| Error::Client(e.into()))?)
+    Frame::try_from(&*frame.data).map_err(|e| Error::Client(e.into()))
 }
 
 #[cfg(test)]

libsql-server/src/replication/snapshot.rs

@@ -117,7 +117,7 @@ async fn compact(
     snapshot_dir_path: &Path,
     to_compact_path: &Path,
 ) -> anyhow::Result<()> {
-    match perform_compaction(&db_path, to_compact_file, log_id).await {
+    match perform_compaction(db_path, to_compact_file, log_id).await {
         Ok((snapshot_name, snapshot_frame_count, size_after)) => {
             tracing::info!("snapshot `{snapshot_name}` successfully created");
 
@@ -133,7 +133,7 @@ async fn compact(
                 bail!("failed to register snapshot with snapshot merger: {e}");
             }
 
-            if let Err(e) = std::fs::remove_file(&to_compact_path) {
+            if let Err(e) = std::fs::remove_file(to_compact_path) {
                 bail!("failed to remove old log file `{to_compact_path:?}`: {e}",);
             }
         }
@@ -192,7 +192,7 @@ impl LogCompactor {
 
         let (sender, mut receiver) = mpsc::channel::<(LogFile, PathBuf)>(8);
         let mut merger = SnapshotMerger::new(db_path, log_id)?;
-        let snapshot_dir_path = snapshot_dir_path(&db_path);
+        let snapshot_dir_path = snapshot_dir_path(db_path);
 
         let db_path = db_path.to_path_buf();
         // We gather pending snapshots here, so new snapshots don't interfere.

libsql-server/tests/cluster/replication.rs

@@ -128,10 +128,10 @@ fn apply_partial_snapshot() {
                 .unwrap();
             let stats = resp.json_value().await.unwrap();
             let replication_index = &stats["replication_index"];
-            if !replication_index.is_null() {
-                if replication_index.as_i64().unwrap() == primary_replication_index {
-                    break;
-                }
+            if !replication_index.is_null()
+                && replication_index.as_i64().unwrap() == primary_replication_index
+            {
+                break;
             }
             tokio::time::sleep(Duration::from_millis(1000)).await;
         }

libsql/src/de.rs

@@ -44,10 +44,7 @@ impl<'de> Deserializer<'de> for RowDeserializer<'de> {
                 match self.idx.next() {
                     None => Ok(None),
                     Some(i) => {
-                        let value = self
-                            .row
-                            .get_value(i as i32)
-                            .map_err(|e| DeError::custom(e))?;
+                        let value = self.row.get_value(i as i32).map_err(DeError::custom)?;
                         self.value = Some(value);
                         self.row
                             .column_name(i as i32)

libsql/src/transaction.rs

@@ -16,7 +16,7 @@ pub struct Transaction {
     pub(crate) inner: Box<dyn Tx + Send + Sync>,
     pub(crate) conn: Connection,
     /// An optional action executed whenever a transaction needs to be dropped.
-    pub(crate) close: Option<Box<dyn FnOnce() -> ()>>,
+    pub(crate) close: Option<Box<dyn FnOnce()>>,
 }
 
 impl Transaction {