Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setPresenceStatus status_msg defaults to null #79

Closed
auscompgeek opened this issue Mar 17, 2020 · 0 comments · Fixed by #218
Closed

setPresenceStatus status_msg defaults to null #79

auscompgeek opened this issue Mar 17, 2020 · 0 comments · Fixed by #218
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@auscompgeek
Copy link

If an undefined status_msg is passed to setPresenceStatus, status_msg defaults to null which gets literally sent to the server, leading to an M_UNKNOWN status_msg must be a string.

status_msg should default to undefined to be omitted from the JSON entirely.

Ref: matrix-org/matrix-appservice-discord#591
@turt2live turt2live added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Mar 17, 2020
auscompgeek added a commit to auscompgeek/matrix-bot-sdk that referenced this issue Aug 30, 2020
@auscompgeek
Allow omitting some optional fields
6a5c7c6 
Presence, membership, and profile changes have optional fields.
These should be omitted rather than null when unwanted.

Fixes: turt2live#79
@auscompgeek auscompgeek mentioned this issue Aug 30, 2020
Closed
@Half-Shot Half-Shot mentioned this issue Feb 20, 2021
Closed
@jaller94 jaller94 mentioned this issue May 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
2 participants
@auscompgeek @turt2live