Allow omitting some optional fields #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presence, membership, and profile changes have optional fields. These should be omitted rather than null when unwanted. Fixes: turt2live#79
|
Many of these are null for specific reasons, largely for server compatibility in off-spec behaviour. |
|
Hmm. Do you have any documentation for these broken behaviours anywhere? |
|
nope, hence "off-spec" :p Most of it is synapse, though there's other implementations out there that rely on a literal null value. |
|
Hmmm. Well, we already have clients that omit the kick/ban reason when unspecified, and we know #79 is a problem with Synapse. If it's just the profile change endpoints that have problems with being omitted, I can change those signatures back I guess. |
|
tbh I'd rather push forward on the spec side than trya nd fix/document all the problems in the library. |
Sorunome
reviewed
Aug 30, 2020
Closed
|
closing this per spec concerns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presence, membership, and profile changes have optional fields.
These should be omitted rather than null when unwanted.
Fixes: #79