Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carousel): adds css theme variables #2350

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

HarperGG
Copy link
Collaborator

@HarperGG HarperGG commented Feb 8, 2022

@vercel
Copy link

vercel bot commented Feb 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/Bm9c5n8m8gbaarsCdQi96aNBSJWA
✅ Preview: https://naive-ui-git-fork-harpergg-feat-carousel-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #2350 (6d3313c) into main (c1c22cc) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2350      +/-   ##
==========================================
- Coverage   63.62%   63.45%   -0.17%     
==========================================
  Files         946      946              
  Lines       19137    19240     +103     
  Branches     4825     4871      +46     
==========================================
+ Hits        12175    12208      +33     
- Misses       5851     5883      +32     
- Partials     1111     1149      +38     
Impacted Files Coverage Δ
src/carousel/src/Carousel.tsx 52.53% <0.00%> (-1.24%) ⬇️
src/result/src/Result.tsx 69.04% <0.00%> (-30.96%) ⬇️
src/empty/src/Empty.tsx 74.41% <0.00%> (-19.53%) ⬇️
src/descriptions/src/Descriptions.tsx 79.72% <0.00%> (-12.34%) ⬇️
src/page-header/src/PageHeader.tsx 83.72% <0.00%> (-10.88%) ⬇️
src/code/src/Code.tsx 66.66% <0.00%> (-5.89%) ⬇️
src/input-number/src/InputNumber.tsx 62.80% <0.00%> (-4.19%) ⬇️
src/log/src/Log.tsx 42.85% <0.00%> (-1.71%) ⬇️
src/watermark/src/Watermark.tsx 53.12% <0.00%> (-0.21%) ⬇️
src/form/src/FormItem.tsx 38.51% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c22cc...6d3313c. Read the comment docs.

@XieZongChen XieZongChen linked an issue Feb 8, 2022 that may be closed by this pull request
@07akioni
Copy link
Collaborator

07akioni commented Feb 8, 2022

感觉这种用 props 之类的实现更合适一点,这变量太长了,应该抽象抽象

@HarperGG
Copy link
Collaborator Author

HarperGG commented Feb 9, 2022

感觉这种用 props 之类的实现更合适一点,这变量太长了,应该抽象抽象

这样写感觉可以更加灵活的去控制高度和宽度的比例,给两个属性来控制会不会太冗余了一点,但是名字确实是有点长了。

@lgtm-com
Copy link

lgtm-com bot commented Feb 21, 2022

This pull request introduces 1 alert when merging 57e0e5b into c1c22cc - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@HarperGG
Copy link
Collaborator Author

HarperGG commented Mar 1, 2022

@07akioni 现在这种处理呢

@07akioni
Copy link
Collaborator

07akioni commented Mar 1, 2022

@07akioni 现在这种处理呢

周末我看一下哈

@07akioni 07akioni merged commit baf35e0 into tusen-ai:main Mar 26, 2022
@07akioni
Copy link
Collaborator

经过我一段时间的研究,最终还是决定使用 prev-slide-stylenext-slide-style 来搞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel添加属性
2 participants