Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upload #243

Merged
merged 4 commits into from
Jun 23, 2021
Merged

Feature/upload #243

merged 4 commits into from
Jun 23, 2021

Conversation

Fnzero
Copy link
Collaborator

@Fnzero Fnzero commented Jun 22, 2021

Fix #135

@vercel
Copy link

vercel bot commented Jun 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/5mdGYfLBjqkM91g5fYVHUnJVWKvt
✅ Preview: https://naive-ui-git-fork-fnzero-feature-upload-tusimple.vercel.app

@lgtm-com
Copy link

lgtm-com bot commented Jun 22, 2021

This pull request introduces 1 alert when merging 6bbb6f2 into 4316282 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

src/upload/demos/zhCN/controlled.demo.md Outdated Show resolved Hide resolved
src/upload/demos/zhCN/index.demo-entry.md Outdated Show resolved Hide resolved
src/upload/src/Upload.tsx Outdated Show resolved Hide resolved
src/upload/src/Upload.tsx Outdated Show resolved Hide resolved
@@ -55,7 +57,8 @@ export interface UploadInjection {
onDownloadRef: Ref<OnDownload | undefined>
XhrMap: Map<string, XMLHttpRequest>
submit: (fileId?: string) => void
doChange: DoChange
doChange: DoChange,
handleFileListChange: () => void
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没必要

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #243 (bf59144) into main (44946ec) will decrease coverage by 0.00%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   31.97%   31.97%   -0.01%     
==========================================
  Files         505      505              
  Lines       12009    12014       +5     
  Branches     3268     3270       +2     
==========================================
+ Hits         3840     3841       +1     
- Misses       7451     7455       +4     
  Partials      718      718              
Impacted Files Coverage Δ
src/upload/src/interface.ts 100.00% <ø> (ø)
src/upload/src/Upload.tsx 14.84% <16.66%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44946ec...bf59144. Read the comment docs.

CHANGELOG.en-US.md Outdated Show resolved Hide resolved
src/upload/demos/enUS/controlled.demo.md Outdated Show resolved Hide resolved
src/upload/demos/enUS/index.demo-entry.md Outdated Show resolved Hide resolved
src/upload/src/Upload.tsx Outdated Show resolved Hide resolved
src/upload/src/Upload.tsx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make file list two way binded in controlled mode of upload
2 participants