Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pagination): improve quickJump #2945

Merged
merged 4 commits into from
May 17, 2022
Merged

feat(pagination): improve quickJump #2945

merged 4 commits into from
May 17, 2022

Conversation

MinatoHikari
Copy link
Contributor

#2928

  1. 过滤 quickJump 输入字符为纯 int
  2. 下标越界时取最大/最小值

@vercel
Copy link

vercel bot commented May 15, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
naive-ui ❌ Failed (Inspect) May 17, 2022 at 1:28PM (UTC)

@MinatoHikari
Copy link
Contributor Author

pnpm run dev
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/apple/project/naive-ui/src/anchor/src/styles/index.cssr' imported from /Users/apple/project/naive-ui/src/anchor/src/AnchorAdapter.tsx
跑不起来啊，怎么会是呢

@Sepush
Copy link
Collaborator

Sepush commented May 15, 2022

pnpm run dev Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/apple/project/naive-ui/src/anchor/src/styles/index.cssr' imported from /Users/apple/project/naive-ui/src/anchor/src/AnchorAdapter.tsx 跑不起来啊，怎么会是呢

因为 esno 版本升级挂了 我在 #2943 把版本降级回了 0.14.1 还没合

Sepush
Sepush reviewed May 15, 2022
View reviewed changes
CHANGELOG.zh-CN.md Outdated Show resolved Hide resolved
src/pagination/src/utils.ts Show resolved Hide resolved
src/pagination/src/utils.ts Show resolved Hide resolved
@MinatoHikari
- correct changelog
14aec27 
- rename doJumpQuick to getJumpQuickPage and call doUpdatePage outside
@MinatoHikari
Copy link
Contributor Author

调整了一下，这样可以运行测试用例，也不会有无意义的返回值
changelog 修改了，添加了英文的changelog

@07akioni 07akioni merged commit ca8fe66 into tusen-ai:main May 17, 2022
@lgtm-com
Copy link

lgtm-com bot commented May 17, 2022

This pull request introduces 1 alert when merging ca16289 into b123dfd - view on LGTM.com

new alerts:

  • 1 for Syntax error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@07akioni 07akioni 07akioni left review comments

@Sepush Sepush Sepush left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MinatoHikari @Sepush @07akioni