Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu tooltip #370

Merged
merged 3 commits into from
Jul 3, 2021
Merged

Fix menu tooltip #370

merged 3 commits into from
Jul 3, 2021

Conversation

07akioni
Copy link
Collaborator

@07akioni 07akioni commented Jul 3, 2021

fix #338

@vercel
Copy link

vercel bot commented Jul 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/EgFKccJYr62hTZhvDNSRbH3zdTWJ
✅ Preview: https://naive-ui-git-fix-menu-tooltip-tusimple.vercel.app

@07akioni 07akioni temporarily deployed to test July 3, 2021 17:03 Inactive
@07akioni 07akioni temporarily deployed to test July 3, 2021 17:03 Inactive
@07akioni 07akioni temporarily deployed to test July 3, 2021 17:05 Inactive
@07akioni 07akioni temporarily deployed to test July 3, 2021 17:05 Inactive
@codecov
Copy link

codecov bot commented Jul 3, 2021

Codecov Report

Merging #370 (43d4436) into main (47a67a2) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage   34.34%   34.35%           
=======================================
  Files         508      508           
  Lines       12112    12113    +1     
  Branches     3313     3312    -1     
=======================================
+ Hits         4160     4161    +1     
- Misses       7157     7158    +1     
+ Partials      795      794    -1     
Impacted Files Coverage Δ
src/menu/src/MenuOption.tsx 54.54% <ø> (ø)
src/menu/src/styles/index.cssr.ts 100.00% <ø> (ø)
src/popover/src/PopoverBody.tsx 63.23% <0.00%> (ø)
src/popover/src/Popover.ts 68.37% <100.00%> (+0.27%) ⬆️
src/tooltip/src/Tooltip.ts 80.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47a67a2...43d4436. Read the comment docs.

@07akioni 07akioni merged commit 8579578 into main Jul 3, 2021
@07akioni 07akioni deleted the fix-menu-tooltip branch July 3, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant