feat(message): messageProvider add closable prop #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tusimple/naive-ui/CJjhbR84ARmRzkmVBPJhdBr9q9Rb |
Codecov Report
@@ Coverage Diff @@
## main #797 +/- ##
==========================================
- Coverage 40.25% 40.25% -0.01%
==========================================
Files 507 507
Lines 12393 12394 +1
Branches 3479 3480 +1
==========================================
Hits 4989 4989
Misses 6494 6494
- Partials 910 911 +1
Continue to review full report at Codecov.
|
Fnzero
approved these changes
Aug 6, 2021
XieZongChen
reviewed
Aug 6, 2021
| @@ -182,6 +183,11 @@ export default defineComponent({ | |||
| ? this.duration | |||
| : message.duration | |||
| } | |||
| closable={ | |||
| message.closable === undefined | |||
There was a problem hiding this comment.
要判断填没填，没填才是默认，填了的话就不能再被覆盖了
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #795