-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(message): messageProvider add closable prop #797
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tusimple/naive-ui/CJjhbR84ARmRzkmVBPJhdBr9q9Rb |
Codecov Report
@@ Coverage Diff @@
## main #797 +/- ##
==========================================
- Coverage 40.25% 40.25% -0.01%
==========================================
Files 507 507
Lines 12393 12394 +1
Branches 3479 3480 +1
==========================================
Hits 4989 4989
Misses 6494 6494
- Partials 910 911 +1
Continue to review full report at Codecov.
|
@@ -182,6 +183,11 @@ export default defineComponent({ | |||
? this.duration | |||
: message.duration | |||
} | |||
closable={ | |||
message.closable === undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为啥不用 falsy ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
要判断填没填,没填才是默认,填了的话就不能再被覆盖了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
开个新 PR 把测试搞了
OK |
close #795