Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockquote in toots have no style #1271

Closed
Aldarone opened this issue May 19, 2019 · 4 comments · Fixed by #4091
Closed

Blockquote in toots have no style #1271

Aldarone opened this issue May 19, 2019 · 4 comments · Fixed by #4091
Milestone

Comments

@Aldarone
Copy link

I'm using the glitch-soc flavour of mastodon which doesn't strip some nice html tags like strong em etc...

When a toot contains a blockquote there is a default style which is really not good looking compared to the web interface.

Tusky :

WebUI :

@mal0ki
Copy link
Member

mal0ki commented May 19, 2019

Thank you for bringing this to our attention!

@charlag
Copy link
Collaborator

charlag commented May 19, 2019

Yup, thanks for reporting! I don't know how to easily do it though, maybe with span?.. we use automatic Android conversion from HTML for most things and it seems to ignore this thing.

@Aldarone
Copy link
Author

I found this : https://stackoverflow.com/a/29114976

I thinking about adding a private method in StatusBaseViewHolder to do the formatting before setting the call to setSpoilerAndContent, is this the right way to do it ?

@connyduck
Copy link
Collaborator

Stackoverflow post looks interesting! No this should not be in StatusBaseViewHolder. We do a lot of span manipulating in LinkHelper, but I think the best place would be to do it where the HTML is actually parsed so its not called that often. Maybe SpannedTypeAdapter or HtmlUtils.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants