Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version detection for post scheduling #2439

Closed
connyduck opened this issue Apr 16, 2022 · 5 comments
Closed

Remove version detection for post scheduling #2439

connyduck opened this issue Apr 16, 2022 · 5 comments

Comments

@connyduck
Copy link
Collaborator

We currently check the version of the active Mastodon instance to decide whether to enable post scheduling or not.
This was relevant 2 years agon when post scheduling was new, but now virtually no instance runs a version below 2.7.0 anymore.
The code and the corresponding tests can be removed.

@Arteneko
Copy link

Trying my hand at it right now

@guntbert
Copy link
Contributor

@connyduck Do you want to keep the no longer needed member supportsScheduled in InstanceInfo (and just set its value to true when calling the constructor)?
If we remove it that might have consequences for code calling InstanceInfo()

guntbert pushed a commit to guntbert/Tusky that referenced this issue Apr 27, 2022
@guntbert
Copy link
Contributor

@Arteneko are you working on this? I don´t want to step on your toes 😉

@connyduck
Copy link
Collaborator Author

@connyduck Do you want to keep the no longer needed member supportsScheduled in InstanceInfo (and just set its value to true when calling the constructor)?
If we remove it that might have consequences for code calling InstanceInfo()

I'd remove it (and adjust the callsites accordingly ofc)

@Arteneko
Copy link

I am not, tried to work on it but I can't seem to even compile the app or run the tests due to random JVM errors

guntbert pushed a commit to guntbert/Tusky that referenced this issue Apr 28, 2022
guntbert pushed a commit to guntbert/Tusky that referenced this issue Apr 28, 2022
connyduck pushed a commit that referenced this issue Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants