Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If phone screen is small, notification filters cannot be set #2985

Closed
mcclure opened this issue Dec 5, 2022 · 3 comments · Fixed by #3004
Closed

If phone screen is small, notification filters cannot be set #2985

mcclure opened this issue Dec 5, 2022 · 3 comments · Fixed by #3004

Comments

@mcclure
Copy link
Collaborator

mcclure commented Dec 5, 2022 •
edited

Spoke to a user on Mastodon who said she could not change her notification filters in Tusky. She then posted a screenshot of the filter pane in which the "apply" button did not appear. What seems to be happening is her screen is not tall enough and Apply gets cut off:

screenshot

Probably before "edits" was added this would not have been a problem.

When I told her content was cut off she said if she scrolls down so the top bar disappears, the pane is taller and she sees Apply. But she shouldn't have to do that.

I know her phone model but she has asked me not to post it on public github.

Expected behavior: ???
@mcclure mcclure changed the title If screen is short, notification filters cannot be set If phone screen is small, notification filters cannot be set Dec 5, 2022
@nikclayton
Copy link
Contributor

This is reproducible in an emulator based on the Nexus 4 template.

@nikclayton
Copy link
Contributor

Will be fixed with #3004

connyduck pushed a commit that referenced this issue Dec 6, 2022
Ensure the "Apply" button is always visible (#3004)
48ad2f9 
On smaller devices the notification filter listview may be longer than the
screen height, and pushes the "Apply" button out of sight.

Fix this by:

- Set the height of the listview to 0dp and its layout_weight to 1
- Set the layout_weight of the button to 0

This ensures the button always appears (because the listview height is 0dp)
and the listview then expands to fill any remaining space (because the
layout_weight is 1).

Fixes #2985
@mcclure
Copy link
Collaborator Author

mcclure commented Dec 7, 2022

Aeva confirms fixed https://mastodon.social/@aeva@mastodon.gamedev.place/109473657444671100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure the "Apply" button is always visible
2 participants
@mcclure @nikclayton