Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boosting a post that's just an image shows an empty dialog #3308

Closed
1 task done
nikclayton opened this issue Feb 11, 2023 · 2 comments · Fixed by #3418
Closed
1 task done

Boosting a post that's just an image shows an empty dialog #3308

nikclayton opened this issue Feb 11, 2023 · 2 comments · Fixed by #3418

Comments

@nikclayton
Copy link
Contributor

Boost a post like https://mstdn.social/@Dark_phoenix/109831170941464918 which is an image only, no text.

If you have confirmations turned on you are shown an empty confirmation dialog.

Screenshot_20230211-204503

  • Tusky Version: 21

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
@Lakoja
Copy link
Collaborator

Lakoja commented Mar 3, 2023

The actual fix would maybe be rather simple (in StatusBaseViewHolder#showConfirmReblogDialog).

However there are a number of questions that popped up for me when working there (sorted from big to small):

  • Do we need these confirmation dialogs for boost and favorite at all? I guess it's yes because otherwise you wouldn't necessarily know what that button does? However this solves a help question with an "Are you sure" dialog. And "Are sou sure" is not necessary here as it can be easily undone (just tap button again).
  • This dialog shows only the text. For example a poll is also missing. Also if there is (a bit of) text and image it is odd that the dialog only shows the text. I guess if it shows any content it should show all of it (which would make much more complicate).
  • If images are not shown in the dialog, what should be shown instead as text? "an attachment"? The alt text?
  • If this is an "Are you sure" dialog, does it need a title? But I'm pretty sure it also needs a cancel / No button.
  • The dialog shows all text. This might be too much to show on a screen.

So, actually, I have no real solution here.
I would remove the dialog/option but I guess we can't do that as it is already present and might be used by some?

Maybe a compromise would be:

  • Only show a real "Are you sure" dialog (without content but with title).
  • This dialog could then also have a checkbox for deactivating it/the option.

@nikclayton
Copy link
Contributor Author

Do we need these confirmation dialogs for boost and favorite at all?

Yes, but for (I think) a more important reason than the ones you've listed. These buttons cause a change to the user's data that is visible by other users.

Bookmarking doesn't, so that doesn't need a confirmation. And replying requires the user to complete multiple steps to confirm they want to reply.

But these two, by default, should require the confirmation.

But this doesn't necessarily have to be a dialog. What if it popped up a menu where the option was "Boost as [account]" (https://developer.android.com/reference/android/widget/PopupMenu) ?

  1. That would require the same number of taps as exist right now to boost with confirmation
  2. The menu would be clearly attached to the button, so it's clear which status is involved -- no need to duplicate the status.
  3. If the user has multiple accounts this could show multiple options, allowing them to boost a status from one of their other accounts, without needing to switch (this would also solve Feature request: "Boost as ..." #2793)

Interaction rules would be:

  • If the user has "confirm boost" enabled and one account, show the menu on click
  • If the user has "confirm boost" disabled and one account, boost immediately on click
  • If the user has "confirm boost" disabled, and multiple accounts, boost immediately on click, show the menu on long-click only

And do the same thing for favourites.

connyduck pushed a commit that referenced this issue Mar 18, 2023
Show reblog/favourite confirmations as menus not dialogs (#3418)
c36b243 
* Show reblog/favourite confirmations as menus not dialogs

The previous code used dialogs and displayed the text of the status when
reblogging or favouriting.

This didn't work when the post just contained images, and other material
from the status (content warning, polls) was not shown either.

Fix this by displaying a popup menu instead. The status remains visible so
the user can clearly see what they're acting on.

In addition, this lays the groundwork for supporting a long-press menu
in the future to allow the user to reblog/favourite from a different
account.

Fixes #3308

* Revert the change that puts the menu immediately over the icon

Although this behavious is consistent with how the option menu works, I
decided that the risk of someone inadvertently double-tapping in the same
location, and the first tap opens the menu and the second tap confirms the
action was too great.

So now the menu appears either above or below the icon depending on space,
and the user has to tap in two slightly different spaces.

This is also consistent with the previous behaviour, where it's highly
unlikely that the confirm button on the dialog would have been directly
under the user's finger if they double-tapped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show reblog/favourite confirmations as menus not dialogs
2 participants
@nikclayton @Lakoja