Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Animated .png emotes don't render correctly #3631

Closed
1 task done
Sirs0ri opened this issue May 6, 2023 · 6 comments · Fixed by #3676
Closed
1 task done

[Bug] Animated .png emotes don't render correctly #3631

Sirs0ri opened this issue May 6, 2023 · 6 comments · Fixed by #3676

Comments

@Sirs0ri
Copy link
Contributor

Sirs0ri commented May 6, 2023

I noticed that animated .png emotes / emojis don't render correctly in the Tusky nightlies. They either don't render at all, or they're not the size they should be. They are never animated. In the current stable Version (21) they render as they should, and animated .gif emotes are always rendered correctly, in both versions.

Some screenshots, the :ablobcatrainbow: emote (animated .png) failed to render, while :confusedlucy: (a .gif file) renders just fine. When I started taking these, the emote wouldn't show up at all, but after moving through a few pages and refreshing posts here and there I started seeing the "broken and scaled up" version of the emote.

link to the toot
:ablobcatrainbow: file
:confusedlucy: file

emote completely missing from a feed-view
emote rendered broken in thread-view
emote rendered broken on the profile view

Please LMK if there's any additional info you need! Thanks for looking into it.


  • Tusky Version:

    • Test 22.0 beta 2-d2747811
  • Android Version: Android 12 / OneUI 4.1

  • Android Device: Samsung Galaxy s10e

  • Mastodon instance (if applicable): definitely happens on corteximplant.com, but I'm not sure if it's limited to our instance.

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.

@connyduck
Copy link
Collaborator

Can reproduce, logcat is spammed with FrameAnimationDrawable onRender:Buffer not large enough for pixels while the post is visible 😲

@connyduck
Copy link
Collaborator

connyduck commented May 18, 2023

  1. We are loading all emojis in their full size, which is inefficient
  2. Even if I specify the correct size, the animated emoji in question still fails to display
  3. If i go even lower, I get the weird "broken and scaled up" version
  4. Seems like a bug in the Apng library?

@connyduck
Copy link
Collaborator

Yes, definitely a bug, downgrading to 2.23.0 fixes the problem, but upgrading to 2.25.0 does not. Will report to the maintainer. Should we downgrade in the meantime?

@nikclayton
Copy link
Contributor

I agree with a downgrade if it fixes the problem. Seems like a reasonable thing to rev a new beta over.

@Tak
Copy link
Collaborator

Tak commented May 19, 2023

+1 for downgrade - was there a particular feature we upgraded for?

@connyduck
Copy link
Collaborator

Bug report: penfeizhou/APNG4Android#188
Downgrade: #3676

was there a particular feature we upgraded for?

No, it was auto-upgraded by Renovate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants