Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix crash in TimelineFragment #1159

Merged
merged 1 commit into from Mar 28, 2019
Merged

fix crash in TimelineFragment #1159

merged 1 commit into from Mar 28, 2019

Conversation

connyduck
Copy link
Collaborator

Fix this shit AGAIN, this time for real hopefully.

The steps to reproduce it this time are:

  • Find a hashtag where only one users posts, go to that hashtags timeline (or add it as a tab)
  • mute that one user
  • crash

thx to @MasterGroosha for finding it

closes #1087

@connyduck connyduck added this to the Tusky 6 milestone Mar 27, 2019
@connyduck connyduck requested a review from charlag March 27, 2019 17:46
charlag
charlag approved these changes Mar 27, 2019
View reviewed changes
Copy link
Collaborator

@charlag charlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn ><
That's my mistake.
Good that we've found it.
These indexed accesses, amirite?

@connyduck connyduck merged commit 51a3e0e into master Mar 28, 2019
pandasoft0 pushed a commit to roma-apps/roma-android that referenced this pull request Mar 29, 2019
@connyduck @joelpyska
fix crash in TimelineFragment (tuskyapp#1159)
91f18c0
@connyduck connyduck deleted the fix_timeline_fragment_crash branch April 10, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlag charlag charlag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Tusky 6
Development

Successfully merging this pull request may close these issues.

Fix handling of empty timeline
2 participants
@connyduck @charlag