Make "Up" and "Overflow" menu icons more visible in AccountProfile #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toolbar in AccountProfile is transparent, so any profile image the user has chosen is shown under it. This makes the "Up" and "Overflow" menu icons also have transparent backgrouns. Consequently, they can be hard to spot, or possibly invisible, on backgrounds that are very dark or very light. Fix this by compositing the icons in a LayerDrawable, with a circular background identical to the surface colour. This ensures they stand out against the background image, and blend in when the user scrolls.
connyduck
reviewed
Feb 20, 2023
app/src/main/java/com/keylesspalace/tusky/components/account/AccountActivity.kt
Outdated
Show resolved
Hide resolved
A bit, but not much. It's very easy to go too transparent and then on pathological backgrounds everything ends up camouflaged again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toolbar in AccountProfile is transparent, so any profile image the user has chosen is shown under it.
This makes the "Up" and "Overflow" menu icons also have transparent backgrounds.
Consequently, they can be hard to spot, or possibly invisible, on backgrounds that are very dark or very light.
Fix this by compositing the icons in a LayerDrawable, with a circular background identical to the surface colour. This ensures they stand out against the background image, and blend in when the user scrolls.
Fixes #2723