Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Hide compose button while scrolling" setting with bottom padding #4486

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

connyduck
Copy link
Collaborator

@connyduck connyduck commented Jun 2, 2024

As discussed in our contributors meeting.

Advantages:

  • last element of list never obscured by action button
  • less code that runs on every scroll
  • less settings to worry about

Additionally:

  • Added a (smaller) padding to the bottom of lists without action button, I think it looks nice if there is a bit of white space and the nav bar divider and the last list divider don't touch.
  • The list of filters had no dividers, I added them.
  • Recyclerviews with fixed height (Drafts, Filters, edits) now have scrollbars
  • code formatted all touched xml files

closes #1563

@connyduck connyduck requested review from Tak and charlag June 2, 2024 17:09
@connyduck connyduck merged commit 34b53a3 into develop Jun 5, 2024
3 checks passed
@connyduck connyduck deleted the remove-fab-hide branch June 5, 2024 17:36
connyduck added a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floating Action Button covers the last element of a scroll-list of toots.
2 participants