some Optimizations for tablets #647
Conversation
|
Step two: limit timeline width on larger devices. Onfurtunately, I found no way of doing this without an additional
|
|
Rather than limiting timeline width, perhaps try for a multi-column approach? If not that, then maybe figure out a better use for the whitespace around the edges (putting notifications on the side of the timelines?) |
|
I will only do stuff that can be achieved with layout/style changes because I do not want to add additional code complexity or spend much time on this. Yes, multi column would be awesome, but its too big of a change for now. |
|
Ok so I think I got the most important stuff. I will fix the AboutActivity once #646 is done. |
| <?xml version="1.0" encoding="utf-8"?> | ||
| <shape xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <corners android:radius="5dp" /> | ||
| <solid android:color="@color/window_background_dark" /> |
There was a problem hiding this comment.
- Maybe pull out radius to dimen?
- Maybe you could create one drawable but color resource would be actually different?
| @@ -0,0 +1,20 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
I was surprised that when it's not ConstraintLayout there's no maxWidth
* show ComposeActivity as Dialog on tablets * limit timeline width on large devices * limit width on large devices for thread view and search * increase media preview size on large devices
resolves #421
Step one: Show ComposeActivity as a dialog on tablets!