Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix account switching when offline/error #830

Merged
merged 1 commit into from Sep 3, 2018
Merged

Conversation

connyduck
Copy link
Collaborator

closes #829

not sure why this is happening, it may be a bug in the MaterialDrawer library. Now it works, although it is a small perf hit because of the additional headerResult.clear();

@connyduck
Copy link
Collaborator Author

maybe this also fixes #763

@charlag
Copy link
Collaborator

charlag commented Sep 3, 2018

I've been looking at the code embarrassingly long and I think it's okay? Performance hit is surely neglectable

@connyduck connyduck merged commit 0b3bee0 into master Sep 3, 2018
@connyduck connyduck deleted the fix_account_switching branch September 3, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing account fails if one of the instances returns an error.
2 participants