add checkmark to verified links and better constraints to account fields #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
connyduck
commented
Nov 18, 2018
connyduck
commented
charlag
approved these changes
Nov 18, 2018
| LinkHelper.setClickableText(viewHolder.valueTextView, emojifiedValue, null, linkListener) | ||
|
|
||
| if(field.verifiedAt != null) { | ||
| TextViewCompat.setCompoundDrawablesRelativeWithIntrinsicBounds(viewHolder.valueTextView, 0, 0, R.drawable.ic_check_circle, 0) |
There was a problem hiding this comment.
Do we still need to use compat?
There was a problem hiding this comment.
No you are right, we don't. I will remove it from everywhere else as well.
| app:layout_constrainedWidth="true" | ||
| app:layout_constraintWidth_max="160dp" | ||
| tools:text="Field title " /> | ||
| app:layout_constraintWidth_percent=".3" |
There was a problem hiding this comment.
Not clear why .3 is needed here. Perhaps a comment is needed.
There was a problem hiding this comment.
I just think it looks best, no technical reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.