Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create overlay for buble text field suggestions #2949

Closed
bedhub opened this issue Apr 16, 2021 · 4 comments · Fixed by #2986 or #3056
Closed

Create overlay for buble text field suggestions #2949

bedhub opened this issue Apr 16, 2021 · 4 comments · Fixed by #2986 or #3056
Assignees
Labels
improvement nice-to-haves that are not impeding usage of any features state:tested We tested it and are about to release it
Milestone

Comments

@bedhub
Copy link
Contributor

bedhub commented Apr 16, 2021

Right now the suggestions list from the bubble text field in mail editor changes the content size of the mail editor. This leads to not very nice movement of the content when typing in the mail address. We should make a real overlay for the suggestion list and also refactor the bubble text field input to the new component style.

@bedhub bedhub added the improvement nice-to-haves that are not impeding usage of any features label Apr 16, 2021
@bedhub bedhub modified the milestones: Next release, Roadmap Apr 16, 2021
@bedhub bedhub changed the title Suggestion from bubble text field should not move content of component Suggestions from bubble text field should not move content of component Apr 16, 2021
@bedhub bedhub changed the title Suggestions from bubble text field should not move content of component Create overlay for buble text field suggestions Apr 16, 2021
@vaf-hub vaf-hub self-assigned this Apr 19, 2021
@vaf-hub vaf-hub modified the milestones: Roadmap, Next release May 3, 2021
@vaf-hub
Copy link
Contributor

vaf-hub commented May 3, 2021

Test notes have been moved below

@johnbotris
Copy link
Contributor

johnbotris commented May 12, 2021

  • In the sharing dialog, the bottom of the overlay will be cut off if it extends past the end. A scrollbar also appears on the dialog which shrinks the width (fixing the first problem should fix the second).
  • If the list is scrollable, when using the arrow keys the selection will go out of view, rather than scrolling the list to keep it visible

@vaf-hub vaf-hub self-assigned this May 17, 2021
vaf-hub added a commit that referenced this issue May 17, 2021
vaf-hub added a commit that referenced this issue May 17, 2021
johnbotris added a commit that referenced this issue May 17, 2021
We now will show up to two lines of text for the title, and any more
will be scrollable.

Also, disable horizontal scrolling for the description field and use
`word-wrap: break-word` instead.
vaf-hub added a commit that referenced this issue May 17, 2021
vaf-hub added a commit that referenced this issue May 17, 2021
johnbotris added a commit that referenced this issue May 18, 2021
We now will show up to two lines of text for the title, and any more
will be scrollable.

Also, disable horizontal scrolling for the description field and use
`word-wrap: break-word` instead.
@charlag charlag assigned charlag and unassigned vaf-hub May 19, 2021
@johnbotris
Copy link
Contributor

johnbotris commented May 19, 2021

Test notes:

This feature should be tested extensively on different devices and screen sizes. So please take some time :-)

  • bubble text field suggestions are shown in a dropdown on top of other content (that should not move around anymore if the number of suggestions changes)
  • test all color themes, different screen sizes and devices
  • test all places, that the BTF is used: MailEditor (To, Cc and Bcc fields), EditCalendarEvent (add guests), and sharing a calendar
  • verify that (height) animation works fine
  • verify the height is calculated correctly and it looks ok at the bottom (also if there are many suggestions)
  • Using the up and down keys to select in the dropdown will cause the list to scroll to keep the selection in view
  • The list will not overflow it's container if too long (check the calendar sharing and template sharing dialogs)

@charlag
Copy link
Contributor

charlag commented May 19, 2021

iOS/macOS Safari are also fine. The only thing that doesn't look great is long text cut off horizontally. I think we can fix it later.

@charlag charlag added the state:tested We tested it and are about to release it label May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement nice-to-haves that are not impeding usage of any features state:tested We tested it and are about to release it
Projects
None yet
4 participants