Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix display of large event names in preview #3057

Merged
merged 2 commits into from
May 18, 2021

Conversation

johnbotris
Copy link
Contributor

@johnbotris johnbotris commented May 17, 2021

We now will show up to two lines of text for the title, and any more will be scrollable.

Also, disable horizontal scrolling for the description field and use word-wrap: break-word instead.

Screenshot from 2021-05-17 14-17-35

fix #2899

We now will show up to two lines of text for the title, and any more
will be scrollable.

Also, disable horizontal scrolling for the description field and use
`word-wrap: break-word` instead.
@johnbotris johnbotris requested a review from charlag May 17, 2021 12:21
Copy link
Contributor

@charlag charlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to test on Safari/iOS properly

@@ -271,6 +271,7 @@ styles.registerStyle('main', () => {
'.text-ellipsis': {overflow: 'hidden', 'text-overflow': 'ellipsis', 'min-width': 0, 'white-space': 'nowrap'},
'.min-width-0': {'min-width': 0},
'.text-break': {overflow: 'hidden', 'word-break': 'break-word'},
'.text-wrap': {overflow: 'hidden', 'word-wrap': 'break-word'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as class above

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg I'm blind

`word-wrap` is  just an alias of `overflow-wrap`,
`word-break: break-word` is deprecated in favour of
`overflow-wrap: break-word`, and as far as i can tell they basically do
the same thing.
@johnbotris johnbotris linked an issue May 18, 2021 that may be closed by this pull request
@johnbotris johnbotris merged commit ff3aee3 into master May 18, 2021
@johnbotris johnbotris deleted the event-preview-popup-overflow branch May 18, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

long description & location overflow event popup horizontally
2 participants