Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change picture at final signup step #3989

Closed
12 tasks done
hahub opened this issue Mar 28, 2022 · 0 comments · Fixed by #4528
Closed
12 tasks done

Change picture at final signup step #3989

hahub opened this issue Mar 28, 2022 · 0 comments · Fixed by #4528
Labels
improvement nice-to-haves that are not impeding usage of any features state:done meets our definition of done state:tested We tested it and are about to release it
Milestone
3.100.2

Comments

@hahub
Copy link
Contributor

hahub commented Mar 28, 2022 •
edited by charlag

Change pic to https://tutanota.com/resources/images/team/vis.png at final signup step.

Test Notes

  • Sign up with a new account
  • Choose to make a free account
    • Go through the sign up process
    • Ensure that picture of vis is seen when asked to write down the recovery code.
  • Choose to make a premium account
    • Go through the sign up process
    • Ensure that picture of vis is seen when asked to write down the recovery code.
  • Log-in with free account
  • Perform an action that requires premium (e.g. add external guest to calendar event)
  • Ensure that the reminder image for premium is the picture of hab.
  • Repeat the sign up process for free and premium account again with dark theme
  • Ensure that in both cases the image looks normal, i.e. white background just like with light theme
@hahub hahub added the improvement nice-to-haves that are not impeding usage of any features label Mar 28, 2022
@vitoreiji vitoreiji assigned nif-tutao and ghost Aug 23, 2022
ghost pushed a commit that referenced this issue Aug 23, 2022
@kitsugo
Change picture on final signup
fe09dc9 
The picture on the final signup should be a different one.
Added the new encoded picture and introduced variable to use it in the
desired places.
"Icons.ts" which includes the image is auto-generated and must not
necessarily be merged.

!! Must also merge the commit in tutao-next repo which introduces the
code for the picture to be available in the Icon.ts file via auto-gen !

fixes #3989
@ghost ghost mentioned this issue Aug 23, 2022
Merged
@ghost ghost unassigned nif-tutao and ghost Aug 23, 2022
ghost pushed a commit that referenced this issue Sep 8, 2022
@kitsugo
Change picture on final signup
4bd2abc 
The picture on the final signup should be a different one.
Added the new encoded picture and introduced variable to use it in the
desired places.
"Icons.ts" which includes the image is auto-generated and must not
necessarily be merged.

!! Must also merge the commit in tutao-next repo which introduces the
code for the picture to be available in the Icon.ts file via auto-gen !

fixes #3989
@charlag charlag added the state:done meets our definition of done label Sep 9, 2022
@bedhub bedhub added this to the 3.100.x milestone Sep 19, 2022
@charlag charlag removed their assignment Sep 20, 2022
@charlag charlag modified the milestones: 3.100.x, 3.100.1 Sep 20, 2022
charlag pushed a commit that referenced this issue Sep 20, 2022
@kitsugo @charlag
Change picture on final signup
c6338ad 
The picture on the final signup should be a different one.
Added the new encoded picture and introduced variable to use it in the
desired places.
"Icons.ts" which includes the image is auto-generated and must not
necessarily be merged.

!! Must also merge the commit in tutao-next repo which introduces the
code for the picture to be available in the Icon.ts file via auto-gen !

fixes #3989
@charlag charlag assigned charlag and unassigned charlag Sep 20, 2022
@charlag charlag added the state:tested We tested it and are about to release it label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement nice-to-haves that are not impeding usage of any features state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.100.2
Development

Successfully merging a pull request may close this issue.

Change picture at final signup step tutao/tutanota
4 participants
@charlag @hahub @bedhub @nif-tutao