Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change picture at final signup step #4528

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 23, 2022

The picture on the final signup should be a different one.
Added the new encoded picture and introduced variable to use it in the
desired places.
"Icons.ts" which includes the image is auto-generated and must not
necessarily be merged.

!! Must also merge the commit in tutao-next repo which introduces the
code for the picture to be available in the Icon.ts file via auto-gen !

fixes #3989

Copy link
Contributor

@charlag charlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ramble not towards you: we should stop embedding those icons and just make sure that service worker caches them, the make bundles unnecessarily big.

Otherwise, could you please squash the commits?

src/subscription/UpgradeConfirmPage.ts Outdated Show resolved Hide resolved
The picture on the final signup should be a different one.
Added the new encoded picture and introduced variable to use it in the
desired places.
"Icons.ts" which includes the image is auto-generated and must not
necessarily be merged.

!! Must also merge the commit in tutao-next repo which introduces the
code for the picture to be available in the Icon.ts file via auto-gen !

fixes #3989
@ghost ghost force-pushed the change-picture-at-final-signup-step-3989 branch from da22048 to 4bd2abc Compare September 8, 2022 12:33
@charlag charlag merged commit c6338ad into master Sep 20, 2022
@charlag charlag deleted the change-picture-at-final-signup-step-3989 branch September 20, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change picture at final signup step
2 participants