Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught Error: net::ERR_NETWORK_IO_SUSPENDED (and other node:net errors) #5338

Closed
3 tasks
ganthern opened this issue Apr 4, 2023 · 2 comments · Fixed by #5370
Closed
3 tasks

Uncaught Error: net::ERR_NETWORK_IO_SUSPENDED (and other node:net errors) #5338

ganthern opened this issue Apr 4, 2023 · 2 comments · Fixed by #5370
Labels
bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues state:done meets our definition of done
Milestone

Comments

@ganthern
Copy link
Contributor

ganthern commented Apr 4, 2023

These only happen on linux

woke computer from suspend mode, error message was present on screen

Client: linux
Type: FREE
Tutanota version: 3.111.0
Timestamp (UTC): Mon, 03 Apr 2023 18:19:19 GMT
User agent:
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) tutanota-desktop/3.111.0 Chrome/110.0.5481.179 Electron/23.1.3 Safari/537.36
Error
Error message: net::ERR_NETWORK_IO_SUSPENDED
Stacktrace:
Error: net::ERR_NETWORK_IO_SUSPENDED
at SimpleURLLoaderWrapper.<anonymous> (../../../../home/rab/node:electron/js2c/browser_init:2:49386)
at SimpleURLLoaderWrapper.emit (../../../../home/rab/node:events:513:28)

this one should probably be safe to let the request fail and try again, similar to #5336


Client: linux
Type: PREMIUM
Tutanota version: 3.111.0
Timestamp (UTC): Tue, 04 Apr 2023 16:18:26 GMT
User agent:
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) tutanota-desktop/3.111.0 Chrome/110.0.5481.179 Electron/23.1.3 Safari/537.36
Error
Error message: connect EHOSTUNREACH 2a10:e000:1::16:443
Stacktrace:
Error: connect EHOSTUNREACH 2a10:e000:1::16:443
at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1300:16)

Test Notes

it should be enough to test this on linux.

  • you will need a fixed test version of the desktop client that already has an update it can download

  • you will also need an affected version of the desktop client ( =< 3.112.7)

  • before each test, copy the executables (they overwrite themselves with the update)

  • use the affected version to find a setup that causes the error while the terminal is showing the differential update download (slow down network to 0, pull cable, switch from wired to wifi, turn off VPN, reset router...)

  • do the same with the fixed version

  • no uncaught errors are visible and the update eventually succeeds

Regressions

  • update still works on windows
  • update still works on mac
@ganthern ganthern added bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues labels Apr 4, 2023
@ganthern ganthern changed the title Uncaught Error: net::ERR_NETWORK_IO_SUSPENDED Uncaught Error: net::ERR_NETWORK_IO_SUSPENDED (and other node:net errors) Apr 5, 2023
@charlag
Copy link
Contributor

charlag commented Apr 5, 2023

I'd say convert to offline error

@ganthern ganthern self-assigned this Apr 13, 2023
@ganthern
Copy link
Contributor Author

These are probably caused by this: electron-userland/electron-builder#2398

ganthern added a commit that referenced this issue Apr 14, 2023
includes a fix for uncatchable net errors
during differential downloads

fix #5338
@ganthern ganthern added the state:done meets our definition of done label Apr 14, 2023
@ganthern ganthern added this to the 3.112.7 milestone Apr 14, 2023
charlag pushed a commit that referenced this issue Apr 19, 2023
includes a fix for uncatchable net errors
during differential downloads

fix #5338
charlag pushed a commit that referenced this issue Apr 19, 2023
includes a fix for uncatchable net errors
during differential downloads

fix #5338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues state:done meets our definition of done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants