release: 8.4.0 #401
Merged
release: 8.4.0 #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduced obj.splice calls- instead of calling splice directly within the loop, which can cause array reindexing and performance issues, i've updated this to collect the elements to be deleted in a separate array - losToDelete - and remove them in a subsequent loop. Moving the studentsOnlineList.set([...this.los]) call outside the loop ensures that we only update studentsOnlineList once after all the necessary changes have been made.
new html generator, tutors-gen-lib + restructure tutors-gen
…itle is reference in the title bar and if titles and summeries are present on the page, A click on all topics that already existed, deep topics has been modified and a lot more methods created in the command.ts to acheive a dynamic testing of all the links present within the topics, lo and los etc.
Feat/cypress testing
Tutors generators refactor + fix for sveltekit config issues
…tic html generator, github and web and unit and archive have been included in the testing which had not been previoulsy. A new plugin called cypress-verify-download that verifys the file/folder did download. Also there is a fix in here for issue #385, just the removal of cy.go('back').
…test-tutors-publish-html-398 cypress-testing#398 - This branch, we do extensive testing on the sta…
✅ Deploy Preview for tutors-alpha ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What commits does this PR relate to?
Thank you for your contribution
We hope you stay around and connect with our growing community!