Issue #37 and #28 fixed #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #28
Fixed the issue, removed redundant addition of text object, as creating
and rendering objects again and again is expensive.Now the overlapping of
text in the pause state representation is not there in MotionCommotion and
Migrating Flocks as shown in the snapshot. Also fixed similar issue with
doubleTrouble and catchTheFLow. Tested on Firefox/Edge/Chrome.
Issue #37
Separated pause and replay logic and made the code more modular. Now the replay function can exist without the pause function. Also added a new resume and pause button to represent the pause state more clearly. Fixed this for mindmath.js but a similar implementation would be required for other games as well.