Miscellaneous build fixes #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f36ec17 introduced a compile error wherever this header is included: t4k_common.h:248:1: error: multiple storage classes in declaration specifiers 248 | extern static char wrapped_lines[MAX_LINES][MAX_LINEWIDTH]; //!< Global buffer for wrapped lines. | ^~~~~~ A variable can't be both extern and static. The variable must be declared extern in a header file (which is included in, and compiled as part of, many source files) but defined in exactly one source file in this library. (This variable is not used within this library; but is provided for the convenience of library users and is used by, at least, tuxmath.) See discussion on tux4kids@f36ec17.
Again, these must be declared extern in a header file so that library users can use them, but defined in a single source file.
speech-dispatcher has a pkg-config file so we can use PKG_CHECK_MODULES to easily check for it. Previously it was an error for speech-dispatcher to be missing, even if espeak was present, unless the distributor supplied --without-speech-dispatcher. Simplify the logic and improve the configure --help output. Fixes tux4kids#4 (I hope).
espeak-ng is an actively-maintained fork of espeak, which provides a superset of the espeak 1.48.15 API and ABI.
wjt
force-pushed
the
build-fixes
branch
2 times, most recently
from
be0a2b9
to
c81d3f1
Compare
Check that the code compiles on a recent Ubuntu version with all supported text-to-speech libraries. The build-dependencies are taken from the 't4kcommon' Debian source package.
|
I've compiled and run tuxtype against this branch. I had to do some similar fixups in tuxtype but I haven't had time to tidy those up and submit them. I added GitHub Actions CI to check that the code compiles on Ubuntu with each of the three supported text-to-speech libraries. You can see the results at https://github.com/wjt/t4kcommon/actions. |
This was referenced Dec 18, 2021
phuff
added a commit
to phuff/t4kcommon
that referenced
this pull request
May 12, 2022
…es to tuxmath :) Some of these are similar to tux4kids#10 but there's a minor difference or two
matlacki
added a commit
to matlacki/t4kcommon
that referenced
this pull request
Nov 14, 2023
Closed
|
thanks, merged. |
matlacki
added a commit
to matlacki/t4kcommon
that referenced
this pull request
Nov 14, 2023
…tion of the library, an extra function T4K_LoadMenuArbitraryDirectory() is added unnecessarily to s rc/t4k_menu.c. This is undone in 86b6c26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for issues found while trying to update the Tux Typing Flatpak to a newer toolchain.
Marked as draft because, while I have compiled this code, I have not actually run tuxtype or tuxmath against it.