Allow stopping the MQTT thread early #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SharingMQ.run(): use Event.wait() instead of time.sleep() such that setting the flag also stops the sleep; there is no way to stop time.sleep() in a secondary thread and waiting two hours for _stop_event to take effect is too long;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SharingMQ.run():
use Event.wait() instead of time.sleep() such that setting the flag also
stops the sleep;
there is no way to stop time.sleep() in a secondary thread and waiting
two hours for _stop_event to take effect is too long;