Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Reflect.setPrototypeOf #63

Closed
wants to merge 1 commit into from
Closed

Patch Reflect.setPrototypeOf #63

wants to merge 1 commit into from

Conversation

HeavenVolkoff
Copy link

+requirement of new for instantiating Proxy
+patch Reflect.setPrototypeOf, now accepts null

+patch Reflect.setPrototypeOf, now accepts null
@tvcutsem
Copy link
Owner

tvcutsem commented Dec 1, 2015

Thanks for the patch.

I have been holding off adding the check to require new to invoke the Proxy constructor (it's a documented spec incompatibility in the README) because it will be a breaking change for existing clients of this library. I should probably bite the bullet and upgrade the npm package to 2.x.

Other than better spec compatibility, was there a specific reason you wanted the check?

@HeavenVolkoff
Copy link
Author

Hi man, thank you for the great lib.
About the new check. I added it because I'm writing a es6-ready code, so I thought it would be nice to be warned if i forget to use it somewhere in my code. This way I could avoid future errors when the official Proxy spec becomes supported. Nevertheless, in fact, I completely forgot about compatibility break, but, personally, I think it would be better to add the check at a new lib version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants