Updates lodash to v4.17 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I'll push a new version shortly. It's good to note that node-git-describe does not call defaultsDeep, merge or mergeWith, and therefore isn't truly affected by these CVEs. So if anyone has node-git-describe <=4.0.3 running in production there is no urgent need to upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating lodash to v4.17.11 resolves two vulnaribilities CVE-2018-16487 and CVE-2018-3721.
However I wasn't able to run the tests as most of them already failed due to timeout before the update...Nevermind, Travis succeeded. https://travis-ci.com/saitho/node-git-describe/jobs/176534138