Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #71, added config subcommand and function to set a git remote #77

Merged
merged 3 commits into from
Jun 14, 2020

Conversation

x0f5c3
Copy link
Contributor

@x0f5c3 x0f5c3 commented Jun 14, 2020

#71 Fixed by first converting the Config value into a toml Value then serializing it.
As suggested in Issue #142 - toml-rs
Unfortunately the solution presented later and merged into master doesn't apply to this so the first workaround had to be used.
Also added a way to create a new config and configure the repo including changing the path from the default using dialoguer MultiSelect and Select prompts and by adding a new subcommand with two command line switches. To allow setting a new repo path and creating one locally I also had to add a function to set a git remote for the repository.
Code has been formatted with RustFmt and checked with clippy.
If there's anything that needs to be fixed or changed for this to work then please let me know.

@tversteeg
Copy link
Owner

tversteeg commented Jun 14, 2020

Thanks a lot, this is looking good! Could you add a small section of how the new flag works at the bottom of README.md? If you do that I'll merge it :)

Repository owner deleted a comment from allcontributors bot Jun 14, 2020
@tversteeg

This comment has been minimized.

@allcontributors

This comment has been minimized.

@tversteeg tversteeg merged commit ed76150 into tversteeg:master Jun 14, 2020
@x0f5c3
Copy link
Contributor Author

x0f5c3 commented Jun 14, 2020

Thanks for merging, I think there is more stuff I could add so I'll probably make more requests in the future since I really like the project.

@tversteeg
Copy link
Owner

Thanks for the kind words, looking forward to seeing your pull requests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants