Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CountertopTopology to TypeScript #194

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

slifty
Copy link
Member

@slifty slifty commented Jul 26, 2023

This PR is a continuation of the TypeScript conversion project, moving up to the CountertopTopology class.

Related to #153

@slifty slifty force-pushed the 153-typescript-countertop-topology branch from c8350b5 to 9c443da Compare July 26, 2023 23:59
There is some temporary lint disabling as we wait for the countertop
utilities to get converted.

Issue #153
@slifty slifty force-pushed the 153-typescript-countertop-topology branch from 9c443da to a352f8b Compare July 27, 2023 00:00
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #194 (9c443da) into main (a7a5183) will decrease coverage by 0.46%.
The diff coverage is 100.00%.

❗ Current head 9c443da differs from pull request most recent head a352f8b. Consider uploading reports for the commit a352f8b to get more accurate results

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   86.59%   86.13%   -0.46%     
==========================================
  Files          19       19              
  Lines         440      440              
  Branches       82       82              
==========================================
- Hits          381      379       -2     
- Misses         59       60       +1     
- Partials        0        1       +1     
Flag Coverage Δ
javascript 96.50% <ø> (-1.76%) ⬇️
typescript 81.14% <100.00%> (+2.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/classes/Countertop.js 93.33% <ø> (ø)
src/tools/utils/countertop.js 95.74% <ø> (-4.26%) ⬇️
src/classes/CountertopStation.ts 78.26% <100.00%> (ø)
src/classes/CountertopTopology.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@slifty slifty merged commit 00f5a1b into main Jul 27, 2023
2 checks passed
@slifty slifty deleted the 153-typescript-countertop-topology branch July 27, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant