New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move some bundled libraries no new lisp/bundled/ directory #15

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@tarsius
Copy link

tarsius commented Apr 8, 2016

Please consider the following change:

This is done to avoid putting potentially outdated versions on the
load-path where they might end up shadowing more recent upstream
versions.

The new file lisp/bundled/.nosearch prevents
normal-top-level-add-subdirs-to-load-path from
adding the containing directory to the load path.

When requiring a FEATURE that was moved to the new lisp/bundled/
directory, we no longer use

(require 'feature)

Instead we use

(or (require 'feature nil t)
(require 'feature "bundled/feature"))

This first tries to load feature from a library that can be found on
the `load-path' and if and only if that fails it tries to load it from a
library that can be found in a directory bundled/ that is a subdirectory
of a directory on the load path.

Also note that I have only moved libraries which I know are bundled because I detected a conflict based on my work on the Emacsmirror. There are likely other libraries which should be moved to the lisp/bundled/ directory.

move some bundled libraries no new lisp/bundled/ directory
This is done to avoid putting potentially outdated versions on the
`load-path' where they might end up shadowing more recent upstream
versions.

The new file lisp/bundled/.nosearch prevents
`normal-top-level-add-subdirs-to-load-path' from
adding the containing directory to the load path.

When requiring a FEATURE that was moved to the new lisp/bundled/
directory, we no longer use

  (require 'feature)

Instead we use

  (or (require 'feature nil t)
      (require 'feature "bundled/feature"))

This first tries to load `feature' from a library that can be found on
the `load-path' and if and only if that fails it tries to load it from a
library that can be found in a directory bundled/ that is a subdirectory
of a directory on the load path.
@tvraman

This comment has been minimized.

Copy link
Owner

tvraman commented Apr 9, 2016

@tarsius

This comment has been minimized.

Copy link

tarsius commented Apr 30, 2016

I'm planning to delete the bundled libs

Even better.

But I'm guessing that doesn't apply to the two bundled copies of tetris.el (at lisp/tetris.el and lisp/obsolete/emacspeak-new-tetris.el). These should already be part of current Emacs releases and it would be safe to remove them now.

@tvraman

This comment has been minimized.

Copy link
Owner

tvraman commented Apr 30, 2016

@tarsius

This comment has been minimized.

Copy link

tarsius commented Apr 30, 2016

Alright, so I'll wait for the post-25.1 fix for the other bundled libraries. Thanks.

@tarsius

This comment has been minimized.

Copy link

tarsius commented Mar 21, 2018

Please let me know whether you still intend to eventually unbundle some of these libraries. Thanks!

@tvraman

This comment has been minimized.

Copy link
Owner

tvraman commented Mar 22, 2018

@tarsius

This comment has been minimized.

Copy link

tarsius commented Mar 22, 2018

amixer, analog, folding, nm, sudoku, tapestry and tetris are still bundled though.

@tvraman

This comment has been minimized.

Copy link
Owner

tvraman commented Mar 23, 2018

@tarsius

This comment has been minimized.

Copy link

tarsius commented Mar 23, 2018

folding is in tvr/

What is tvr/? A directory intended for bundled libraries? If so, would it be possible to add a .nosearch in that directory to tell tools that populate load-path or collect features that are provided by a package to not look in there?

analog is not there

It is in tvr/.

amixer etc are part of emacspeak.

I see now that there are two amixer implementations. Your's is older, so I will probably remove the other from the Emacsmirror.

Anyway, I was mainly asking to see whether I can close this issue now. The Emacsmirror can now ignore bundled libraries packages better than it used to, so this is not a big deal anymore.

Thanks for taking the time to reply!

@tarsius tarsius closed this Mar 23, 2018

tvraman added a commit that referenced this pull request Nov 21, 2018

Updated download link. Fixes #1, Fixes #2, Fixes #3,Fixes #4,Fixes #5,F…
…ixes #6,Fixes #7,Fixes #8,Fixes #9,Fixes #10,Fixes #11,Fixes #12,Fixes #13,Fixes #14,Fixes #15,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment