move some bundled libraries no new lisp/bundled/ directory #15
Conversation
This is done to avoid putting potentially outdated versions on the
`load-path' where they might end up shadowing more recent upstream
versions.
The new file lisp/bundled/.nosearch prevents
`normal-top-level-add-subdirs-to-load-path' from
adding the containing directory to the load path.
When requiring a FEATURE that was moved to the new lisp/bundled/
directory, we no longer use
(require 'feature)
Instead we use
(or (require 'feature nil t)
(require 'feature "bundled/feature"))
This first tries to load `feature' from a library that can be found on
the `load-path' and if and only if that fails it tries to load it from a
library that can be found in a directory bundled/ that is a subdirectory
of a directory on the load path.
|
We dont need to do this because for now, I'm making sure to
mirror over the bundled libs from Emacs@head. Over time, as Emacs
25 becomes widespread, I'm planning to delete the bundled libs
---so I'd rather not create a mechanism that makes such bundling
an accepted solution.
|
Even better. But I'm guessing that doesn't apply to the two bundled copies of |
|
No. The tetris.el in the emacspeak repo is the one that emacspeak
works with. I tried a while ago to get the newer tetris.el in
emacs working, and failed.
|
|
Alright, so I'll wait for the post-25.1 fix for the other bundled libraries. Thanks. |
|
Please let me know whether you still intend to eventually unbundle some of these libraries. Thanks! |
|
they're unbundled already e.g. dom.el is no longer in the emacspeak
source tree.
--
|
|
amixer, analog, folding, nm, sudoku, tapestry and tetris are still bundled though. |
|
Jonas Bernoulli <notifications@github.com> writes:
There is a good reason for each.
amixer, analog, folding, nm, sudoku, tapestry and tetris are still
bundled though.
sudoku and tetris are intentionally bundled, analog is not there, and
folding is in tvr/.
amixer etc are part of emacspeak.
…
―
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
--
|
What is
It is in
I see now that there are two amixer implementations. Your's is older, so I will probably remove the other from the Emacsmirror. Anyway, I was mainly asking to see whether I can close this issue now. The Emacsmirror can now ignore bundled libraries packages better than it used to, so this is not a big deal anymore. Thanks for taking the time to reply! |
Please consider the following change:
This is done to avoid putting potentially outdated versions on the
load-pathwhere they might end up shadowing more recent upstreamversions.
The new file lisp/bundled/.nosearch prevents
normal-top-level-add-subdirs-to-load-pathfromadding the containing directory to the load path.
When requiring a FEATURE that was moved to the new lisp/bundled/
directory, we no longer use
(require 'feature)
Instead we use
(or (require 'feature nil t)
(require 'feature "bundled/feature"))
This first tries to load
featurefrom a library that can be found onthe `load-path' and if and only if that fails it tries to load it from a
library that can be found in a directory bundled/ that is a subdirectory
of a directory on the load path.
Also note that I have only moved libraries which I know are bundled because I detected a conflict based on my work on the Emacsmirror. There are likely other libraries which should be moved to the
lisp/bundled/directory.