Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rgb and hsl colors opacity support (fix #335) #336

Merged
merged 3 commits into from
Aug 4, 2022
Merged

fix: rgb and hsl colors opacity support (fix #335) #336

merged 3 commits into from
Aug 4, 2022
+28 −8

Conversation

javascriptjedi
Copy link
Contributor

No description provided.

@sastan
Copy link
Collaborator

sastan commented Aug 4, 2022

Thank you. Great idea to do it this way.

I inlined the regexp to reduce code size.

@coveralls
Copy link

coveralls commented Aug 4, 2022 •
edited

Pull Request Test Coverage Report for Build 2795382935

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.463%
Totals Coverage Status
Change from base Build 2299585424: 0.0%
Covered Lines: 7339
Relevant Lines: 7431
💛 - Coveralls

@sastan sastan merged commit b2b7e40 into tw-in-js:next Aug 4, 2022
@github-actions github-actions bot mentioned this pull request Aug 4, 2022
Merged
@sastan sastan mentioned this pull request Aug 4, 2022
Closed
@javascriptjedi javascriptjedi deleted the next-rgb-hsl-opacity-support branch September 13, 2022 22:23
@github-actions github-actions bot mentioned this pull request Oct 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sastan sastan Awaiting requested review from sastan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@javascriptjedi @sastan @coveralls